-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1762 create v3 EsViewMore #1520
CED-1762 create v3 EsViewMore #1520
Conversation
β
Β Linked to Task CED-1762 Β· Create v3 EsViewMore |
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Just a few non-functional comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree adding a note to the EsReview ticket is sufficient. One small nit but LGTM! π
π Linked issue
https://energysage.atlassian.net/browse/CED-1762
β Type of change
π Description
EsViewMore
in Vue 3, no need for primeVue componenthtml-truncate
if (this.$listeners && this.$listeners.click) ...
).However, a check through ES repo usage of this component showed this is not currently used, and I don't think it makes much sense to continue, so removed in this case..π₯Ό Testing
π§ Feedback Requested / Focus Areas
EsReview
with a truncated span+button, since that's the only part of the component really used - but we only need to do that if CDGM is getting upgraded to vue3 at all.π Checklist